ci: add downstream tests for marimo
#1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for working on this! @akshayka fancy taking a look? reckon this would be good enough to cover how you're using narwhals in marimo? |
…exec related issue
akshayka
approved these changes
Oct 14, 2024
mscolnick
reviewed
Oct 14, 2024
| - name: install-marimo-dev | ||
| run: | | ||
| cd marimo | ||
| uv pip install -e ".[dev]" --system |
There was a problem hiding this comment.
do these need to be editable installs? not sure if there is a perf implication
mscolnick
reviewed
Oct 14, 2024
mscolnick
approved these changes
Oct 14, 2024
MarcoGorelli
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
thanks @AlessandroMiola , and @akshayka + @mscolnick for helping out!
the optional test run is a bit long compared with other runs (6 mins, vs usually 2-3 mins), but for now I think it's worth to include it (maybe later if we have too many tests we can only run some on certain tags, but for now i'd say let's play it safe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
Attempt at adding downstream tests for
marimoto the CI pipeline.Notes:
marimo's full test suite also includes additional tests for frontend/cli etc.; I've omitted them as not relevant to the python backend testing functionality.marimoleverages onhatch, thoughpyproject.tomlshows the followingtest:test,test-optional:testandtypecheck:checkdo refer to the followingpytestandmypycommandsAll this said, I've kept the commands as-is (trying to align with the approach in #1161, even though I haven't referenced
makecommands as they do hardcode the python version in within).Please let me know your thoughts on these points so that I can tweak accordingly :) (assuming that everything works as intended 🥶)